Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🗑️ Remove binder link and integrations #300

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Sep 26, 2024

This PR removes the binder and the integration to add a PR comment with a binder link, as well as the workflow that triggers a build on binder when a commit is pushed to main.
The reason to remove binder is that it hasn't been working properly for many months (i.e. timeout when opening) and checking the link in the docs recently also started failing.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

Sorry, something went wrong.

@s-weigand s-weigand requested a review from a team as a code owner September 26, 2024 18:29
Copy link
Contributor

sourcery-ai bot commented Sep 26, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/remove-binder

Verified

This commit was signed with the committer’s verified signature.
s-weigand Sebastian Weigand
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.26%. Comparing base (ba5d46d) to head (dffa9b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   58.26%   58.26%           
=======================================
  Files          31       31           
  Lines        1598     1598           
  Branches      290      290           
=======================================
  Hits          931      931           
  Misses        651      651           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s-weigand s-weigand merged commit 4d38e46 into glotaran:main Sep 26, 2024
31 checks passed
@s-weigand s-weigand deleted the remove-binder branch September 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants